Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: upgrading node version for admin build #802

Open
wants to merge 6 commits into
base: 2.6
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions book/templates.rst
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ from within a block.

.. note::

Because the ``&`` character needs to be escaped inside of XML files, you have to use ``AND`` instead of ``&&``
Because the ``&`` character needs to be escaped inside of XML files, you have to use ``AND`` instead of ``&&``
if you want to connect conditions using a logical and. Additionally, you can use ``OR`` instead of ``||``.

Language Independent Properties
Expand Down Expand Up @@ -942,23 +942,15 @@ node and the ``ref`` attribute:
<block name="blocks" default-type="text_block" minOccurs="0">
<types>
<type ref="text_block" />
<type name="editor">
<meta>
<title lang="en">Editor</title>
<title lang="de">Editor</title>
</meta>
<properties>
<property name="text_editor" type="text_editor">
<meta>
<title lang="en">Text Editor</title>
<title lang="de">Texteditor</title>
</meta>
</property>
</properties>
</type>
</types>
</block>

.. note::

Mixing global and local block types is supported, but it is recommended to keep your block type names unique
to avoid confusion. This approach also simplifies the transition to global blocks in the future, eliminating the need
for data migrations.

Caching
-------

Expand Down
9 changes: 1 addition & 8 deletions bundles/reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,11 @@ and location in which an entity is utilized. Presently, the ReferenceBundle is c
Media within PHPCR entities such as `pages` and `snippets`. These references are managed distinctly for the draft
state within the `admin context` and the live state within the `website context`.

|

The main reason we need this bundle is that, unlike traditional database references, our content management system
operates on an unstructured data model. Therefore, we cannot rely solely on database references, which are usually preferred.
It is essential to note that the ReferenceBundle should only be used for unstructured data, where database relations are
not feasible.

|

Content maintainers are able to see the references to a specific entity in the `Insights` tab of an entity like `Snippet`.

.. figure:: ../img/snippet-insights.png
Expand All @@ -34,7 +30,6 @@ references by executing the `bin/console sulu:references:refresh` command. This

bin/console sulu:references:refresh <resource-key>


.. note::

Please note that references are only refreshed for the current context. To refresh the references for both the
Expand All @@ -47,8 +42,6 @@ To integrate the ReferenceBundle for custom content-types, you need to implement
content-type class. The interface requires you to implement the `getReferences` method. The method already receives the
`ReferenceCollector` which you can use to add references to the collector.

|

Example implementation for a custom content-type:

.. code-block:: php
Expand All @@ -65,4 +58,4 @@ Example implementation for a custom content-type:
(string) $data['id'],
$propertyPrefix . $property->getName()
);
}
}
2 changes: 1 addition & 1 deletion cookbook/build-admin-frontend.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Solution 2: Build manually with docker

.. code-block:: bash

docker run --rm --interactive --tty --volume ${PWD}:/var/project node:14.16.0 /bin/bash
docker run --rm --interactive --tty --volume ${PWD}:/var/project node:20-alpine3.18 /bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add -alpine as they might sometimes make problems so I would keep with the default image and the /bin/bash


# for completion: using another node version is possible by adjusting the tag of the node image
# docker run --rm --interactive --tty --volume ${PWD}:/var/project node:12.21.0 /bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also change this line e.g. using 18.19.0

Expand Down