Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra spec to make sure fail_on can work with custom argument_error_class and failure_class 🌌 #165

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add extra spec to make sure fail_on can work with custom argument_error_class and failure_class 🌌 #165

merged 1 commit into from
Aug 23, 2024

Conversation

sunny
Copy link
Owner

@sunny sunny commented Jul 25, 2024

No description provided.

AnneSottise
AnneSottise approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@AnneSottise AnneSottise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool to have some documentation about argument_error_class, failure_class and fail_on, I probably can do it if you want 👀

@sunny
Copy link
Owner Author

sunny commented Jul 26, 2024

Absolutely, I would love that! ❤️

@sunny sunny merged commit e0d2495 into main Aug 23, 2024
14 checks passed
@sunny sunny deleted the specs-extra-fail-on branch August 23, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnneSottise AnneSottise AnneSottise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunny @AnneSottise