Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-7472] Add async support to ingest handlers #2818

Merged
merged 3 commits into from
Jan 18, 2025
Merged

[SDESK-7472] Add async support to ingest handlers #2818

merged 3 commits into from
Jan 18, 2025

Conversation

eos87
Copy link

@eos87 eos87 commented Jan 16, 2025 •
edited by jira bot
Loading

Purpose

Add async support to ingest handlers

What has changed

  • Adjusted base class to implement async can_handle and apply_rule methods
  • Adjusted references handlers and references to async/await calls

Resolves: SDESK-7472

@eos87 eos87 mentioned this pull request Jan 16, 2025
Merged
@eos87
Fix tests
3f37101 
SDESK-7472
MarkLark86
MarkLark86 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

apps/rules/rule_handlers.py Outdated Show resolved Hide resolved
@eos87 eos87 merged commit 6826a5b into async Jan 18, 2025
16 of 33 checks passed
@eos87 eos87 deleted the hg/SDESK-7472-ingest-handlers-async-support branch January 18, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

@BrianMwangi21 BrianMwangi21 BrianMwangi21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eos87 @BrianMwangi21 @MarkLark86