-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SuperEditor][Web][Guides]: Updates guides for version 0.3.0 (#2429) #2430
base: main
Are you sure you want to change the base?
Conversation
My changes to the quickstart guide will be a good test to see how much you'll allow me to change the current wording. The former wording wasn't bad, I just expand it. I'm also following these principles:
Is it OK to use backticks (`) rather that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments on the initial adjustments to quickstart.md
.
To your question about <code>
tags. Yes you can use backticks instead. In fact, you should only use HTML tags in Markdown when you have no other choice.
@matthew-carroll |
@suragch - Is this actually true, after our recent conversation on Discord? |
doc/website/source/super-editor/guides/document-from-markdown.md
Outdated
Show resolved
Hide resolved
doc/website/source/super-editor/guides/document-from-markdown.md
Outdated
Show resolved
Hide resolved
doc/website/source/super-editor/guides/document-from-markdown.md
Outdated
Show resolved
Hide resolved
@matthew-carroll I've updated two more guides (Assemble a Document and Markdown Parsing). Unfortunately I did that before going through your comments above, so I made some changes that probably weren't in line with your idea of what the guides should be. You can respond to the changes in those guides and I can retract the tutorial style changes I made. In the remainder of the guides, I won't attempt to make many changes. I'll just fix broken syntax. If I write a beginner's guide in the future, I can write it on my own site. |
Our Discord discussion resolved the issue. |
@matthew-carroll In the Add a Popover Toolbar guide, there is the following line:
|
I've reverted several of my previous changes. Partly I had misunderstood the scope and purpose of the edits I was making. The other part was I let my pride get the better of me and tried to argue my side when that wasn't what you wanted for this site. I forgot that I'm here to be a learner. I'm sorry about that. I've left in a few TODO questions. If you have any answers for those, I'll add them in. Otherwise, we can ignore them. I wasn't able to get the Popover guides working. (See my question above about that.) The Add New Type of Content and Add a Mobile Keyboard Toolbar guides are essentially empty. Should we remove those from the menu for now? I'll limit this PR to the Super Editor guides. If I update the Super Reader or Super Text Field guides, I create a new PR for them later. |
This PR aims to update all of the SuperEditor web guides to work with
super_editor
0.3.0 with an eye for first time users.Since I myself am a first time user, my goal is to write the docs that I would have wanted to have. They should not only help the reader to write code that runs but also explain any confusing aspects along the way.
I'm initially submitting this PR as an update to a single guide (SuperEditor Quickstart) for early feedback and will then ping the reviewer at various intervals afterwards (after every guide to start with). The PR doesn't need to be merged until all of the guides are finished.