Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Модульные тесты часть 1 #124

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

@mrandrewsmith mrandrewsmith commented Apr 10, 2024

Что сделано

  • Добавлены тесты на часть нод
  • Исправлены опечатки
  • Исправлены ошибки найденные в ходе написания тестов
  • Удалены интеграционные тест (будут возвращены в следующих пр)
  • Исправлена интеграция codecov в github actions

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 72.91667% with 13 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (SPT-1998-combine-support@2121a70). Click here to learn what that means.

❗ Current head 3aa0aed differs from pull request most recent head f8a46ab. Consider uploading reports for the commit f8a46ab to get more accurate results

Files Patch % Lines
NodeKit/Chains/UrlChainsBuilder.swift 0.00% 4 Missing ⚠️
NodeKit/Encodings/UrlJsonRequestEncodingNode.swift 33.33% 2 Missing ⚠️
...tProcessingLayer/MultipartRequestCreatorNode.swift 71.42% 2 Missing ⚠️
NodeKit/Utils/Logging/LoggerNode.swift 0.00% 2 Missing ⚠️
...uestBuildingLayer/UrlRequestTrasformatorNode.swift 0.00% 1 Missing ⚠️
...ers/RequestProcessingLayer/RequestSenderNode.swift 0.00% 1 Missing ⚠️
NodeKit/Utils/AsyncIterator/AnyAsyncIterator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             SPT-1998-combine-support     #124   +/-   ##
===========================================================
  Coverage                            ?   47.51%           
===========================================================
  Files                               ?       95           
  Lines                               ?     2553           
  Branches                            ?        0           
===========================================================
  Hits                                ?     1213           
  Misses                              ?     1340           
  Partials                            ?        0           
Flag Coverage Δ
tests 47.51% <72.91%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests branch 2 times, most recently from 9e1379f to 874b91e Compare April 10, 2024 13:57
Copy link
Contributor

@NullIsOne NullIsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ничего критичного
Вопросы на размышление

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-combine-support branch from b910b36 to a94c1fe Compare April 16, 2024 11:53
@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-combine-support to 5.0.0 April 24, 2024 09:00
@mrandrewsmith mrandrewsmith merged commit 0686d83 into 5.0.0 Apr 24, 2024
1 check passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-unit-tests branch May 7, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants