Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Модульные тесты часть 2 #125

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

@mrandrewsmith mrandrewsmith commented Apr 10, 2024

Что сделано

  • Добавлены тесты на ноды
  • Добавлен актор сохранения таски URLSession для избежания Race condition

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (3aa0aed) to head (7604cdf).
Report is 1 commits behind head on SPT-1998-unit-tests.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           SPT-1998-unit-tests     #125      +/-   ##
=======================================================
+ Coverage                47.51%   56.44%   +8.92%     
=======================================================
  Files                       95       96       +1     
  Lines                     2553     2562       +9     
=======================================================
+ Hits                      1213     1446     +233     
+ Misses                    1340     1116     -224     
Flag Coverage Δ
tests 56.44% <100.00%> (+8.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part2 branch 3 times, most recently from dd62b3b to 5c8ac32 Compare April 10, 2024 13:04
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests branch 2 times, most recently from 9e1379f to 874b91e Compare April 10, 2024 13:57
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part2 branch from 5c8ac32 to 729253a Compare April 10, 2024 14:15
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part2 branch from 729253a to 7604cdf Compare April 16, 2024 12:15
@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-unit-tests to 5.0.0 April 24, 2024 09:01
@mrandrewsmith mrandrewsmith merged commit ba0a840 into 5.0.0 Apr 24, 2024
2 checks passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-unit-tests-part2 branch May 7, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants