Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Интеграционные тесты #128

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

Что сделано

  • Возвращены интеграционные тесты
  • Запросы в тестах перенаправлены на моковый URLSession
  • Изменена структура тестов, распределил файлы по папкам

@mrandrewsmith mrandrewsmith self-assigned this Apr 10, 2024
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part3 branch from a87f777 to 708f2c7 Compare April 10, 2024 08:01
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from a829179 to 3799bcd Compare April 10, 2024 08:01
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part3 branch from 708f2c7 to f23c6ea Compare April 10, 2024 08:05
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 3799bcd to e6cacc8 Compare April 10, 2024 08:05
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part3 branch from 8aa04c0 to 0750775 Compare April 10, 2024 13:17
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch 2 times, most recently from 85c75b3 to 1e742b9 Compare April 10, 2024 13:26
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part3 branch from 90f7a9e to 9dc690e Compare April 10, 2024 14:16
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 1e742b9 to 7f72987 Compare April 10, 2024 14:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (0264256) to head (7110bb1).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           SPT-1998-unit-tests-part3     #128      +/-   ##
=============================================================
+ Coverage                      85.32%   91.59%   +6.26%     
=============================================================
  Files                             82       82              
  Lines                           1261     1261              
=============================================================
+ Hits                            1076     1155      +79     
+ Misses                           185      106      -79     
Flag Coverage Δ
tests 91.59% <ø> (+6.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part3 branch from 9dc690e to 32bc80a Compare April 10, 2024 18:57
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 7f72987 to 65734f5 Compare April 10, 2024 19:06
Copy link
Contributor

@NullIsOne NullIsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Незначительные замечания

NodeKitTests/Mocks/Network/URLResponsesStub.swift Outdated Show resolved Hide resolved
NodeKitTests/Mocks/Network/URLResponsesStub.swift Outdated Show resolved Hide resolved
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-unit-tests-part3 branch from 32bc80a to 0264256 Compare April 16, 2024 12:29
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 65734f5 to 7110bb1 Compare April 16, 2024 12:39
@mrandrewsmith mrandrewsmith requested a review from NullIsOne April 16, 2024 12:39
@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-unit-tests-part3 to 5.0.0 April 24, 2024 09:37
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 7110bb1 to c5e2ee8 Compare April 24, 2024 09:38
@mrandrewsmith mrandrewsmith merged commit f5d11ec into 5.0.0 Apr 24, 2024
1 check passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-integration-tests branch May 7, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants