Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Проверка отмены таски в нодах (3) #132

Merged
merged 2 commits into from
May 24, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

Что сделано

  • Каждая нода теперь проверяет жива ли таска
  • Тесты на новый функционал

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (58cdde8) to head (1ee4784).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           SPT-1998-combine-task-cancelation     #132      +/-   ##
=====================================================================
+ Coverage                              91.02%   91.33%   +0.31%     
=====================================================================
  Files                                     87       87              
  Lines                                   1304     1351      +47     
=====================================================================
+ Hits                                    1187     1234      +47     
  Misses                                   117      117              
Flag Coverage Δ
tests 91.33% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-improve-node-task-cancellation branch from 8a210d5 to 79bc0d6 Compare May 2, 2024 15:54
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-combine-task-cancelation branch from be1212c to f3e65e3 Compare May 2, 2024 15:54
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-improve-node-task-cancellation branch from 79bc0d6 to 1adeaad Compare May 2, 2024 15:54
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-combine-task-cancelation branch from f3e65e3 to f47756f Compare May 7, 2024 04:42
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-improve-node-task-cancellation branch from 1adeaad to 3b40a32 Compare May 7, 2024 04:56
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-combine-task-cancelation branch from f47756f to 58cdde8 Compare May 13, 2024 12:10
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-improve-node-task-cancellation branch from 3b40a32 to 1ee4784 Compare May 13, 2024 12:10
@mrandrewsmith mrandrewsmith changed the title SPT-1998 Проверка отмены таски в нодах SPT-1998 Проверка отмены таски в нодах (3) May 13, 2024
Copy link
Contributor

@chausovSurfStudio chausovSurfStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

честно скажу - в основном глазами пробежался, надеюсь на стабильность работы системы в целом, которую должны обеспечить тесты)

@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-combine-task-cancelation to 5.0.0 May 24, 2024 10:54
@mrandrewsmith mrandrewsmith merged commit f4d057c into 5.0.0 May 24, 2024
3 checks passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-improve-node-task-cancellation branch June 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants