Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Фикс для сборки с ветки (4) #134

Merged
merged 1 commit into from
May 24, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

Что сделано

  • Теперь можно добавлять пакет, ссылаясь на ветку

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (1ee4784) to head (04b4066).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           SPT-1998-improve-node-task-cancellation     #134   +/-   ##
========================================================================
  Coverage                                    91.33%   91.33%           
========================================================================
  Files                                           87       87           
  Lines                                         1351     1351           
========================================================================
  Hits                                          1234     1234           
  Misses                                         117      117           
Flag Coverage Δ
tests 91.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@NullIsOne NullIsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Супер.
Теперь spm видит эту ветку и переключается на нее без проблем.

Отребейзю свою временную ветку 5.0.0-pre-release и оформлю отдельно остальные изменения выскочившие из-за миграции.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-improve-node-task-cancellation branch from 3b40a32 to 1ee4784 Compare May 13, 2024 12:10
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-fix-branch-build branch from 6417752 to 04b4066 Compare May 13, 2024 12:10
@mrandrewsmith mrandrewsmith changed the title SPT-1998 Фикс для сборки с ветки SPT-1998 Фикс для сборки с ветки (4) May 13, 2024
@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-improve-node-task-cancellation to 5.0.0 May 24, 2024 11:00
@mrandrewsmith mrandrewsmith merged commit 8249cb1 into 5.0.0 May 24, 2024
3 checks passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-fix-branch-build branch June 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants