Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust declaration map paths #8843

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: adjust declaration map paths #8843

wants to merge 11 commits into from

Conversation

dummdidumm
Copy link
Member

closes #7793

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2023

🦋 Changeset detected

Latest commit: 3e1548b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Should we do #8825 first? Otherwise we'll need to leave reminders for ourselves to update stuff later

@dummdidumm
Copy link
Member Author

We can, yes. I was just trying to carve out bits of package that I can do without waiting on that decision - merge conflicts are probably minimal, if we do #8825 first.

@Rich-Harris
Copy link
Member

Rich-Harris commented Feb 8, 2023

closing in favour of #8922

@Rich-Harris Rich-Harris closed this Feb 8, 2023
@dummdidumm
Copy link
Member Author

In favor of means that you want to incorporate this into that PR? Because this fix is independent

@asjir
Copy link

asjir commented Mar 18, 2024

I ended up writing

# fixpaths
perl -pi -e 's/("(\.\.\/)+)\.\.\/\.\.\/(?=src\/lib\/)/\1/g' dist/**/*.d.ts.map
perl -pi -e 's/("(\.\.\/)+)\.\.\/\.\.\/(?=src\/lib\/)/\1/g' dist/*.d.ts.map

and adding sh fixpaths to the end of the package script in package.json

note that it's 2 levels too deep now

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-8843-svelte.vercel.app/

this is an automated message

@dummdidumm
Copy link
Member Author

ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:svelte-package Issues related to svelte-package types / typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

declarationMap option in svelte-package
5 participants