Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: Replace lazy_static macro with once_cell #1055

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

svix-nick
Copy link
Contributor

See also #1024

lazy_static is unmaintained, once_cell is the new hotness. This PR swaps out the one lazy_static invocation for the equivalent lazy construct from once_cell.

@svix-nick
Copy link
Contributor Author

⭐ Open source review ⭐

Might not be necessary, but given that this is technically a different project, here's what I said last time:

once_cell is the new standard for lazily-initialized static values. The intent is for its API to be incorporated into the standard library. Parts of it already have been as of Rust 1.70.0.

Our existing solution lazy_static is not maintained, and urges users to move to once_cell.

once_cell is dual licensed Apache 2.0 and MIT, as are all of its dependencies.

@svix-nick svix-nick marked this pull request as ready for review August 24, 2023 22:15
@svix-nick svix-nick requested a review from a team August 24, 2023 22:15
@svix-onelson
Copy link
Contributor

OSS review approved!

@svix-nick svix-nick merged commit 15cfc31 into main Aug 24, 2023
@svix-nick svix-nick deleted the nick/remove-lazy-static branch August 24, 2023 22:52
@svix-nick svix-nick self-assigned this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants