Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing rm text in episode 3 #729

Closed
wants to merge 1 commit into from

Conversation

dbrower
Copy link

@dbrower dbrower commented Mar 11, 2020

The challenge problem to remove a nested git repository at the end of episode 3 has a confusing solution. It uses the term "working tree" that is not used anywhere else in the course. It discusses "working directory" before that is introduced in episode 4. Furthermore, removing the errant .git directory is not the same as "removing files from the repository", and in general an rm command will not remove files from the history of a git repository.

Others have also noticed this problem. Among all the changes in #686 there is a similar edit.

@kekoziar
Copy link
Contributor

kekoziar commented Jul 2, 2021

The original PR and issue indicates a concern of providing a very powerful and potentially dangerous command w/o background. #588, #558, #560
I agree that the prefaced text needs to be clarified since working tree and working directory can be confusing. Feel free to modify your PR to keep the needed background (not everyone will have gone through the shell lesson), while updating the language.

Copy link
Contributor

@kekoziar kekoziar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the prefaced text needs to be clarified since working tree and working directory can be confusing. Feel free to modify your PR to keep the needed background (not everyone will have gone through the shell lesson), while updating the language.
Will mark as abandoned if no response after 1 week.

@kekoziar
Copy link
Contributor

resolved in #753

@kekoziar kekoziar closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants