Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward close params to quit #2185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igxlin
Copy link

@igxlin igxlin commented Jan 9, 2025

It will be helpful to forward close params to quit. Then users can use commands like close --cwd-file, close --no-cwd-file, to control the quit behavior indirectly.

@igxlin igxlin changed the title Forward close params to quit feat: forward close params to quit Jan 9, 2025
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new Opt for the close command like quit does:

struct Opt {
no_cwd_file: bool,
}

to make it safer. Otherwise, when new parameters are added to quit, there could be unintended parameter passthrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants