fix: incorrect monorepo sub-plugin path resolution #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxyazi
changed the title
ya pack deploy path handling
|
Oh right, forgot to test sub-plugins, thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to install a plugin with a format like
yazi-rs/plugins:mime-ext, an error message "No such file or directory" is returned.The error occurs because the constructed local path to the plugin source is missing the
.yaziextension. This results in incorrect paths such asmime-ext/init.luainstead of the correctmime-ext.yazi/init.lua.This patch addresses this issue by ensuring the
.yaziextension is correctly included when constructing the local path for these plugins.Thanks for your amazing work!