API Set extension hook implementation visibility to protected

symbiote · May 20, 2024 · 88bd506 · 88bd506
1 parent d7d9fca
commit 88bd506
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/DataObjects/QueuedJobDescriptor.php b/src/DataObjects/QueuedJobDescriptor.php
@@ -271,7 +271,7 @@ public function cleanupJob()
         }
     }
 
-    public function onBeforeWrite()
+    protected function onBeforeWrite()
     {
         // if a job is marked as 'waiting' for a restart, we need to reset the
         // worker it was assigned to, otherwise it'll never pick up and go again if
@@ -283,7 +283,7 @@ public function onBeforeWrite()
         parent::onBeforeWrite();
     }
 
-    public function onBeforeDelete()
+    protected function onBeforeDelete()
     {
         parent::onBeforeDelete();
         $this->cleanupJob();

diff --git a/src/Extensions/MaintenanceLockExtension.php b/src/Extensions/MaintenanceLockExtension.php
@@ -21,7 +21,7 @@ class MaintenanceLockExtension extends DataExtension
     /**
      * @param FieldList $fields
      */
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         if (!QueuedJobService::config()->get('lock_file_enabled')) {
             return;

diff --git a/src/Extensions/ScheduledExecutionExtension.php b/src/Extensions/ScheduledExecutionExtension.php
@@ -58,7 +58,7 @@ class ScheduledExecutionExtension extends DataExtension
     /**
      * @param FieldList $fields
      */
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $fields->removeByName([
             'ExecuteInterval',
@@ -105,7 +105,7 @@ public function updateCMSFields(FieldList $fields)
         }
     }
 
-    public function onBeforeWrite()
+    protected function onBeforeWrite()
     {
         parent::onBeforeWrite();