Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch schickling/mailcatcher to jeanberu/mailcatcher #1131

Closed
wants to merge 1 commit into from

Conversation

ivoba
Copy link

@ivoba ivoba commented Oct 7, 2022

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

Replace schickling/mailcatcher Docker image with jeanberu/mailcatcher because it is smaller with less MB.
Functionality should be the same.

schickling/mailcatcher: Compressed size: 25.44 MB
https://github.com/schickling/dockerfiles/blob/master/mailcatcher/Dockerfile

jeanberu/mailcatcher: Compressed size: 15.27 MB
https://github.com/Jean-Beru/docker-mailcatcher/blob/master/Dockerfile

This should save some MBs on the internets.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 7, 2022 13:20
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1131/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1131/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/mailer:^4.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@fabpot
Copy link
Member

fabpot commented Jan 18, 2024

Closing in favor of #1281

@fabpot fabpot closed this Jan 18, 2024
auto-merge was automatically disabled January 18, 2024 06:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants