Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluesky notifier #1273

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add bluesky notifier #1273

merged 1 commit into from
Dec 19, 2023

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 16, 2023

Q A
License MIT
Doc issue/PR tomorrow

Related to symfony/symfony#53083

Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1273/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1273/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/bluesky-notifier:^7.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 16, 2023 06:18
@@ -0,0 +1,5 @@
{
"env": {
"#1": "BLUESKY_DSN=bluesky://USER:[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"#1": "BLUESKY_DSN=bluesky://USER:PASS@bsky.social"
"#1": "BLUESKY_DSN=bluesky://USER:PASS@default"

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, there is no default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean in our bridge or in general for Bluesky? I opened a PR

@fabpot fabpot disabled auto-merge December 19, 2023 10:40
@fabpot fabpot merged commit 18a02c4 into symfony:main Dec 19, 2023
1 of 2 checks passed
@Nyholm Nyholm deleted the bluesky branch December 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants