Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier][Pushy] Add recipe for Pushy notifier #1292

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Feb 14, 2024

Q A
License MIT
Doc issue/PR symfony/symfony-docs#19555

Code: symfony/symfony#53927

Copy link

github-actions bot commented Feb 14, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1292/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1292/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/pushy-notifier:^7.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path of the file is wrong as you forgot the version.

@fabpot
Copy link
Member

fabpot commented Feb 15, 2024

symfony/pushy-notifier/manifest.json -> symfony/pushy-notifier/7.1/manifest.json

auto-merge was automatically disabled February 15, 2024 09:02

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 15, 2024 09:02
@stloyd stloyd requested a review from fabpot February 15, 2024 09:05
@symfony-recipes-bot symfony-recipes-bot merged commit a9a2bc1 into symfony:main Feb 15, 2024
1 of 2 checks passed
@stloyd stloyd deleted the patch-1 branch February 15, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants