Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symfony/framework-bundle/7.0 & 7.2] Add imports for services.yaml wi… #1333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[symfony/framework-bundle/7.0 & 7.2] Add imports for services.yaml wi… #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions symfony/framework-bundle/7.0/config/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# This file is the entry point to configure your own services.
# Files in the packages/ subdirectory configure your dependencies.

# There comes imported service files, if you would like to split config to multiple files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# There comes imported service files, if you would like to split config to multiple files.
# Import additional files that should be processed before this file.

# Symfony loads first the imported files and then it processes the parameters and services defined in this file itself.
# Duplicating services will be overridden and last config wins.
Comment on lines +5 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these two lines as one can read the docs at this point.

# https://symfony.com/doc/current/service_container/import.html
imports:

# Put parameters here that don't need to change on each machine where the app is deployed
# https://symfony.com/doc/current/best_practices.html#use-parameters-for-application-configuration
parameters:
Expand Down
6 changes: 6 additions & 0 deletions symfony/framework-bundle/7.2/config/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# This file is the entry point to configure your own services.
# Files in the packages/ subdirectory configure your dependencies.

# There comes imported service files, if you would like to split config to multiple files.
# Symfony loads first the imported files and then it processes the parameters and services defined in this file itself.
# Duplicating services will be overridden and last config wins.
# https://symfony.com/doc/current/service_container/import.html
imports:

# Put parameters here that don't need to change on each machine where the app is deployed
# https://symfony.com/doc/current/best_practices.html#use-parameters-for-application-configuration
parameters:
Expand Down
Loading