Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding core-js #50

Closed
wants to merge 1 commit into from
Closed

Adding core-js #50

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link

@ThomasLandauer ThomasLandauer commented Oct 27, 2021

Is this the right fix for #49 and #47 ? Thanks to @graceman9 and @Kocal, I solved it by doing npm install --save [email protected].
So I'm guessing it might be better to add it here right away.

Closes #49

Is this the right fix for #49 and #47 ? Thanks to @graceman9 and @Kocal, I solved it by doing `npm install --save [email protected]`.
So I'm **guessing** it might be better to add it here right away.
@Kocal
Copy link
Member

Kocal commented Oct 27, 2021

Hi, and thanks for the PR!

I don't think this is the right fix for the core-js issue.
core-js is usually a dependency that should be installed by yourself if you need to us it (ie: need polyfills).

Also, note that dependency core-js should normally be in your package.json if you installed the Webpack Encore bundle (see recipe).

@ThomasLandauer
Copy link
Author

Don't know why it didn't work last week, but now (after starting from scratch) this is my package.json:

{
    "devDependencies": {
        "@symfony/stimulus-bridge": "^2.0.0",
        "@symfony/webpack-encore": "^1.0.0",
        "core-js": "^3.0.0",
        "regenerator-runtime": "^0.13.2",
        "stimulus": "^2.0.0",
        "webpack-notifier": "^1.6.0"
    },
    "license": "UNLICENSED",
    "private": true,
    "scripts": {
        "dev-server": "encore dev-server",
        "dev": "encore dev",
        "watch": "encore dev --watch",
        "build": "encore production --progress"
    }
}

Everything fine so far, so I'm closing this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Stimulus 3 - Webpack Encore is broken right now
2 participants