Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] feat(mailer): Add AhaSend Mailer doc #20361

Open
wants to merge 4 commits into
base: 7.3
Choose a base branch
from

Conversation

farhadhf
Copy link

@farhadhf farhadhf commented Oct 29, 2024

This PR adds the necessary documentation for AhaSend Mailer Bridge and Webhooks.

@carsonbot carsonbot added this to the 7.2 milestone Oct 29, 2024
@carsonbot
Copy link
Collaborator

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Oct 29, 2024
@carsonbot carsonbot modified the milestones: 7.2, next Oct 29, 2024
@carsonbot carsonbot changed the title feat(mailer): Add AhaSend Mailer doc [Mailer] feat(mailer): Add AhaSend Mailer doc Nov 26, 2024
fabpot added a commit to symfony/symfony that referenced this pull request Jan 5, 2025
This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Mailer] Add AhaSend Bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        |
| License       | MIT
| Doc PR | symfony/symfony-docs#20361
| Recipe PR | symfony/recipes#1350

This PR adds support for a new mail bridge for the [AhaSend](https://ahasend.com) email service.
It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.

Commits
-------

3dfad14 [Mailer] Add AhaSend Bridge
symfony-splitter pushed a commit to symfony/mailer that referenced this pull request Jan 5, 2025
This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Mailer] Add AhaSend Bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        |
| License       | MIT
| Doc PR | symfony/symfony-docs#20361
| Recipe PR | symfony/recipes#1350

This PR adds support for a new mail bridge for the [AhaSend](https://ahasend.com) email service.
It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.

Commits
-------

3dfad14c714 [Mailer] Add AhaSend Bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Jan 5, 2025
This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Mailer] Add AhaSend Bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        |
| License       | MIT
| Doc PR | symfony/symfony-docs#20361
| Recipe PR | symfony/recipes#1350

This PR adds support for a new mail bridge for the [AhaSend](https://ahasend.com) email service.
It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.

Commits
-------

3dfad14c714 [Mailer] Add AhaSend Bridge
Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be merged into version 7.3

mailer.rst Outdated Show resolved Hide resolved
@OskarStark OskarStark modified the milestones: next, 7.3 Jan 9, 2025
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Jan 9, 2025
mailer.rst Outdated Show resolved Hide resolved
webhook.rst Outdated Show resolved Hide resolved
@farhadhf farhadhf requested a review from xabbuh as a code owner January 9, 2025 08:12
@xabbuh xabbuh changed the base branch from 7.2 to 7.3 January 9, 2025 08:14
@farhadhf
Copy link
Author

farhadhf commented Jan 9, 2025

Thanks @OskarStark. The requested changes have been made, but I also pulled the latest changes from 7.3 to prevent any potential conflicts and changed the base for this PR to 7.3. Please let me know if this is a problem, we can close this PR and I'll create a fresh one from 7.3.

mailer.rst Outdated Show resolved Hide resolved
Co-authored-by: Christian Flothmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants