[Autocomplete] Only activate clear button plugin when there is a placeholder option #2282
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2024 18:09
…eholder option Placeholder is not necessarily the first option
carsonbot
added
Autocomplete
Bug
smnandre
reviewed
Oct 23, 2024
Comment on lines
+230
to
+231
| const placeholderOptions = Array.from(this.selectElement.options) | ||
| .filter((option) => option.value === ''); |
There was a problem hiding this comment.
Maybe use Array.from(...).find() here ?
(especially as the placeholder will be first element in most of the cases)
There was a problem hiding this comment.
Even .some() that will return you the boolean you need L232 ?
|
Form the monorepository root Install dependenciesCode styleRun TestsBuild dist packages(you need to commit both Please ask if you want/need anymore information :) |
|
Status: Needs work |
carsonbot
added
Status: Needs Work
|
Sorry guys, I somehow missed the review notifications. Will try and clear some time to dive back into this. |
|
No worry, we cannot criticize anyone on time things .... 😅 (well, we cannot criticize anyone on anything just to be clear 😄 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add the
clear_buttonplugin to TomSelect if the form element has no placeholder option.Notes: