-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic instructions to spam-status special scenario. #59
Open
racke
wants to merge
1
commit into
sympa-community:master
Choose a base branch
from
racke:pr/spam-status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more explanations about how is triggered the scenario
spam_status.x-spam-status
could be welcomed ;-)(I guess that setting in global or robot configuration a line
spam_status foo
implies sympa to search for aspam_status.foo
scenario)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it works like any other scenario: the name of the scenario file is composed of the name of the parameter and its value inf the configuration:
parameter.value
I can add it as a remark as the scenario is disconcerting. At least to specify that this parameter can be set in sympa.conf and robot.conf only.
However, we must add that this evaluation always_ takes place for any incoming message.
The only way to skip it is to make a voluntary error in the config file, I guess: pointing a scenario that does not exist. But then you will fill your logs with missing scenario errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated my PR on the PR with your remarks.
Note that the lnk to the spam_status parameter won't work in the markdown file, as the parameter definition URL is completely computed from the parameter definition in the Sympa code. Consequently, it is not present in the documentation sources.
You can read it here: https://sympa-community.github.io/gpldoc/man/sympa_config.5.html#spam_status
Thanks @dcaillibaud!