Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync language files #2363

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: sync language files #2363

merged 1 commit into from
Nov 26, 2024

Conversation

limpbrains
Copy link
Collaborator

Description

Sync language files

Linked Issues/Tasks

Type of change

Refactoring

Tests

No test

@limpbrains limpbrains requested a review from pwltr November 26, 2024 20:15
Copy link
Collaborator

@pwltr pwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know who does these but seeing how fast translations are being submitted for new strings makes me assume these are generated/auto-translated. Can only validate German translation but some of these are pretty bad. IMO it's better to leave text untranslated (English) than be incomprehensible. I'm happy to review for German before we open these PRs in the future.

@limpbrains
Copy link
Collaborator Author

I've excluded German

@limpbrains limpbrains merged commit 50ef930 into master Nov 26, 2024
7 checks passed
@limpbrains limpbrains deleted the locsync29 branch November 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants