chore: remove unnecessary quotes in type annotations #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 21 21
Lines 1596 1596
=======================================
Hits 1560 1560
Misses 36 36 🚨 Try these New Features:
|
6 tasks
noahnu
approved these changes
Nov 13, 2024
noahnu
reviewed
Nov 13, 2024
| @@ -295,8 +295,8 @@ def _assert(self, data: "SerializableData") -> bool: | |||
| snapshot_name = self.extension.get_snapshot_name( | |||
| test_location=self.test_location, index=self.index | |||
| ) | |||
| snapshot_data: Optional["SerializedData"] = None | |||
| serialized_data: Optional["SerializedData"] = None | |||
| snapshot_data: Optional[SerializedData] = None | |||
There was a problem hiding this comment.
@epenet Does this require from __future__ import annotations? or this is fine in py3.8?
There was a problem hiding this comment.
It is fine as it is.
Fully compatible with 3.8
There was a problem hiding this comment.
(And all 3.8 tests passed to show it)
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA, based on https://docs.astral.sh/ruff/rules/quoted-annotation/
Related Issues
Checklist
Additional Comments
No additional comments.