Fix compilation due to syscall module name conflict #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linD026
requested changes
Dec 22, 2023
In Debian, the name syscall conflicts with this patch: in debian kernel source tree: debian/patches/features/x86/x86-make-x32-syscall-support-conditional.patch mailing list url: https://lore.kernel.org/lkml/[email protected]/T/#u which introduces a parameter named syscall.x32. So change our name.
sys_call_table is already declared in arch/x86/include/asm/syscall.h but of cource not exported by the kernel. before this commit, gcc complains as follows: /usr/src/linux-headers-6.1.0-16-common/arch/x86/include/asm/syscall.h:21:29: note: previous declaration of 'sys_call_table' with type 'long int (* const[])(const struct pt_regs *)' 21 | extern const sys_call_ptr_t sys_call_table[];
linD026
approved these changes
Dec 22, 2023
jserv
changed the title
|
Thank @keytouch for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename sys_call_table to _sys_call_table to fix compile error
sys_call_table is already declared in arch/x86/include/asm/syscall.h but of cource not exported by the kernel.
And rename syscall module name to syscall_steal because In Debian, the name syscall conflicts with the patch debian/patches/features/x86/x86-make-x32-syscall-support-conditional.patch