Implement simplefs_file_open #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the registration of simplefs_file_ops callbacks, there is no open operation, which may lead to creating unexpected space. This commit adds an open operation to handle file truncation when opening files with O_WRONLY, O_RDWR, and O_TRUNC flags. This prevents unintended space allocation by ensuring proper truncation of files. The implementation checks the flags associated with the file opening mode and performs truncation if the file is being opened for write or read/write and the O_TRUNC flag is set. Truncation is achieved by reading the file's index block from disk, iterating over the data block pointers, releasing the associated data blocks, and updating the inode metadata (size and block count). Close #issue55
|
Thank @HotMercury for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the registration of simplefs_file_ops callbacks, there is no open operation, which may lead to creating unexpected space. This commit adds an open operation to handle file truncation when opening files with O_WRONLY, O_RDWR, and O_TRUNC flags. This prevents unintended space allocation by ensuring proper truncation of files.
The implementation checks the flags associated with the file opening mode and performs truncation if the file is being opened for write or read/write and the O_TRUNC flag is set. Truncation is achieved by reading the file's index block from disk, iterating over the data block pointers, releasing the associated data blocks, and updating the inode metadata (size and block count).
Close #55