Fix symlink block allocation mismatch causing unlink bitmap errors #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR indeed fixes the symbolic link bug. |
|
Updated. |
jserv
changed the title
jserv
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Consolidate the test suite to reflect the proposed changes as @HotMercury requested.
When we create symbolic link, in simplefs_new_inode function, the symbolic does not use ei_block to record the using block. But in simplefs_unlink functoin we use the ei_block to clean the bitmap, this makes the unlink will clean the "0" bit in bitmap. Close sysprog21#58
inode_dec_link_count has included drop_nlink/ mark_inode_dirty
|
Thank @RoyWFHuang for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create symbolic link, in simplefs_new_inode function, the symbolic
does not use ei_block to record the using block. But in simplefs_unlink function we use the ei_block to clean the bitmap, this makes the unlink will clean the "0" bit in bitmap.
Close #58
Also fixing the warning messages.
the inode_dec_link_count has included drop_nlink and mark_inode_dirty