Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing continue if pandoc is not available #3339

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

behrmann
Copy link
Contributor

@behrmann behrmann commented Jan 9, 2025

Without the continue, the run on the next line will call die if pandoc is not available, thus breaking the fallback for subsequent formats.

Without the continue, the run on the next line will call die if pandoc is not
available, thus breaking the fallback for subsequent formats.
@DaanDeMeyer
Copy link
Contributor

If pandoc is the only format we'll fail silently if we add this

@behrmann
Copy link
Contributor Author

Running mkosi --doc-format pandoc documentation still prints the warning and since this will only ever be used interactively, I think this is fine.

@DaanDeMeyer DaanDeMeyer merged commit fe188ce into systemd:main Jan 10, 2025
31 of 36 checks passed
@behrmann behrmann deleted the manfallback branch January 10, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants