removes timeout from HTTP server

Signed-off-by: Bruno Calza <[email protected]>

handlers.go

@@ -51,7 +51,12 @@ func (h *Handlers) Upload(rw http.ResponseWriter, r *http.Request) {
 		Shard: result.Shard.String(),
 	}
 
-	bytes, _ := json.Marshal(response)
+	bytes, err := json.Marshal(response)
+	if err != nil {
+		slog.Error("json marshalling", err)
+		rw.WriteHeader(http.StatusInternalServerError)
+		return
+	}
 	_, _ = rw.Write(bytes)
 }
 

main.go

@@ -30,11 +30,8 @@ func main() {
 	router.get("/api/v1/health", handlers.Health)
 
 	srv := &http.Server{
-		Addr:         fmt.Sprintf("0.0.0.0:%s", cfg.HTTP.Port),
-		WriteTimeout: time.Second * 15,
-		ReadTimeout:  time.Second * 15,
-		IdleTimeout:  time.Second * 60,
-		Handler:      router.r,
+		Addr:    fmt.Sprintf("0.0.0.0:%s", cfg.HTTP.Port),
+		Handler: router.r,
 	}
 
 	// Run our server in a goroutine so that it doesn't block.

uploader.go

@@ -249,15 +249,11 @@ func newW3sclient(sk string, proofBytes []byte) (*w3sclient, error) {
 }
 
 func (c *w3sclient) upload(root cid.Cid, dest string) (cid.Cid, error) {
+	// no need to close the file here, because the http client will do.
 	f, err := os.Open(fmt.Sprintf("%s.car", dest))
 	if err != nil {
 		return cid.Undef, err
 	}
-	defer func() {
-		if err := f.Close(); err != nil {
-			slog.Error("close file", err)
-		}
-	}()
 
 	stat, err := f.Stat()
 	if err != nil {
@@ -297,7 +293,6 @@ func (c *w3sclient) upload(root cid.Cid, dest string) (cid.Cid, error) {
 		for k, v := range rcpt.Out().Ok().Headers.Values {
 			hdr[k] = []string{v}
 		}
-
 		hr.Header = hdr
 		hr.ContentLength = int64(size)
 		httpClient := http.Client{