fix: bump go-w3up, check content headers #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
go-w3up
and also makes the change it implements here.Details
content-length
check is all we need, and things work without updating togo-w3up v0.0.3
...but we might as well bump it since it doesn't affect the behavior. If needed, we can remove the dep update and usego-w3up v0.0.2
, and things will work.How it was tested
go-w3up v0.0.3
, and I still received an empty server response, with the server logging this error:rcpt.Out().Ok().Headers.Values
for thecontent-length
, and then uploading random / new files worked: