mark ethers as a package dependency #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewagner
commented
May 23, 2024
| @@ -95,6 +94,7 @@ | |||
| "typescript": "^5.0.2" | |||
| }, | |||
| "dependencies": { | |||
| "@openzeppelin/contracts": "4.9.6" | |||
| "@openzeppelin/contracts": "4.9.6", | |||
| "ethers": "^6.12.0" | |||
There was a problem hiding this comment.
I added a patch bump of @nomicfoundation/hardhat-ethers and a minor bump for @openzeppelin/hardhat-upgrades, but the main change here is adding ethers as a dependency instead of a dev dependency.
joewagner
requested review from
sanderpick,
carsonfarmer and
dtbuchholz
as code owners
dtbuchholz
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ethers is currently a devDep, but in order to build with typescript this package must have the correct ethers version. This means any package using this and a different version of ethers will not build correctly.
Details
A user reported an issue using ethers v5 and v6 in the same packages here: https://discord.com/channels/592843512312102924/968582612945870878/1242050427982315645
The fix involves publishing a version of this package with ethers as a dep, and then publishing a version of the sdk that uses the new version of this package.
If anyone wants to test this out, I published
nexttagged versions for both today.https://www.npmjs.com/package/@tableland/sdk?activeTab=versions
https://www.npmjs.com/package/@tableland/evm?activeTab=versions
The user who reported the issue has a small test app you can use here:
https://github.com/mlegls/tableland-ethers-5-demo/tree/main