adjustments from review

tarioch · Sep 27, 2021 · 1fcbc87 · 1fcbc87
1 parent 57aa067
commit 1fcbc87
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -4,7 +4,7 @@
 ## Usage
 
 ```
--   repo: https://github.com/tarioch/pre-commit-hooks
+-   repo: https://github.com/tarioch/pre-commit-flux
     rev: v0.1.0
     hooks:
     -   id: check-flux-helm-values

diff --git a/pre_commit_hooks/__init__.py → pre_commit_flux/__init__.py b/pre_commit_hooks/__init__.py → pre_commit_flux/__init__.py
diff --git a/pre_commit_hooks/check_flux_helm_values.py → pre_commit_flux/check_flux_helm_values.py b/pre_commit_hooks/check_flux_helm_values.py → pre_commit_flux/check_flux_helm_values.py
@@ -3,7 +3,7 @@
 import subprocess
 import sys
 import tempfile
-
+from shlex import quote
 import yaml
 
 
@@ -58,7 +58,7 @@ def _validateFile(fileToValidate, repos):
                         yaml.dump(definition["spec"]["values"], valuesFile)
 
                 res = subprocess.run(
-                    f"helm pull --repo {chartUrl} --version '{chartVersion}' {chartName}",
+                    f"helm pull --repo {quote(chartUrl)} --version '{quote(chartVersion)}' {quote(chartName)}",
                     shell=True,
                     cwd=tmpDir,
                     text=True,

diff --git a/setup.cfg b/setup.cfg
@@ -1,5 +1,5 @@
 [metadata]
-name = pre_commit_hooks
+name = pre_commit_flux
 
 [options]
 packages = find:
@@ -9,4 +9,4 @@ install_requires =
 
 [options.entry_points]
 console_scripts =
-    check-flux-helm-values = pre_commit_hooks.check_flux_helm_values:main
+    check-flux-helm-values = pre_commit_flux.check_flux_helm_values:main