-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update import defer tests for evaluation triggers #4341
Conversation
9f47897
to
d1f0226
Compare
I tried running this in my webkit prototype that's been updated to the new semantics, and as far as I can tell the test cases all run and agree with the implementation. |
I think this is probably working as intended — the |
No, because the generator parses that code, finds |
@nicolo-ribaudo asked me to take another look at this to check the coverage, and so I looked through the test cases and as far as I can tell it covers the evaluation trigger cases for module namespaces in the spec well. So LGTM. |
Please file an issue for this |
9950d13
to
40dd470
Compare
Ref #4215.
This updates the tests that check what operations trigger evaluation of deferred modules, based on consensus in the last TC39 meeting. It's effectively what is included in tc39/proposal-defer-import-eval#53.
This PR doesn't include tests about what the results of those operations are (which will need to be tested for
.then
).I suggest reviewing commit-by-commit:
All the tests are auto-generated from templates.
There is a bug with templates btw: their
desc
cannot start with[
, because the generator will not escape/prefix it and so it becomes a Yaml array. I had to prefix all the descs with_
for this reason.