v0 improvements #12
Merged
v0 improvements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding bip370 test vectors prefix the current tests.
This file got here somehow while I was doing the bip174 tests, it should never have been here, remove it.
To be uniform with how we name bip files in `rust-bitcoin` remove the hyphen from test file names.
The test files do not need links to the bip.
|
I'm going to merge straight away, nothing unusual here except the usage of the signing API which should have been in the |
We provide a signing API for ECDSA inputs, use it. (Includes some minor cleanups.)
tcharding
force-pushed
the
12-13-v0-improvements
branch
from
c0bc5a4 to
5a653ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements found while working on #8.