Implement message headers #338
Conversation
Implement message headers
|
Of course, this is an API proposal, not ready yet :) |
Ah, got it, didn't realize, thanks for clarifying. |
|
(Consider converting this to a Draft PR) |
| -- send: 4 args with integer delay | ||
| CREATE FUNCTION pgmq.send( | ||
| queue_name TEXT, | ||
| msg JSONB, | ||
| headers JSONB, | ||
| delay INTEGER | ||
| ) RETURNS SETOF BIGINT AS $$ | ||
| SELECT * FROM pgmq.send(queue_name, msg, headers, clock_timestamp() + make_interval(secs => delay)); | ||
| $$ LANGUAGE sql; |
There was a problem hiding this comment.
Consider replacing the variants with just two using defaults:
-- send: 4 args with integer delay
CREATE FUNCTION pgmq.send(
queue_name TEXT,
msg JSONB,
headers JSONB DEFAULT = NULL,
delay INTEGER DEFAULT = 0
) RETURNS SETOF BIGINT AS $$
SELECT * FROM pgmq.send(queue_name, msg, headers, clock_timestamp() + make_interval(secs => delay));
$$ LANGUAGE sql;
CREATE FUNCTION pgmq.send(
queue_name TEXT,
msg JSONB,
headers JSONB DEFAULT = NULL,
delay TIMESTAMP WITH TIME ZONE = clock_timestamp(),
) RETURNS SETOF BIGINT AS $$
SELECT * FROM pgmq.send(queue_name, msg, headers, delay);
$$ LANGUAGE sql;There was a problem hiding this comment.
I think it's not equivalent. I'm accepting pgmq.send(queue_name, msg, integer/timestamp) too
There was a problem hiding this comment.
@theory, I think your suggestion results in a breaking API change? The 3-argument calls would become ambiguous.
I tried the suggestion locally and then ran tests...
+ERROR: function pgmq.send(unknown, unknown, jsonb) is not unique
+LINE 1: SELECT * from pgmq.send('test_unlogged_queue', '{"hello": "w...
+ ^
+HINT: Could not choose a best candidate function. You might need to add explicit type casts.
If this is the case, I would like hold on the breaking API changes v2.0 release.
| SELECT * FROM pgmq.send_batch(queue_name, msgs, NULL, clock_timestamp() + make_interval(secs => delay)); | ||
| $$ LANGUAGE sql; | ||
|
|
||
| -- send batch: 3 args with timestamp |
There was a problem hiding this comment.
Again, try using DEFAULT expressions in parameter lists to reduce the number of variants.
|
i can help for merging this? |
We do need some tests! |
|
I think it's complete now |
| END; | ||
| $$ LANGUAGE plpgsql; | ||
|
|
||
| -- Update existing queues |
Closes #203
Needed for #294