Fix subdirectories, tabs in control file (#891) #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Fix a few issues working with the `directory` field from control files:
* `emaj` failed to work because it has a tab on the `directory` line
of its control file. Fix `strip_value` to account for any and all
blank space on either side of the `=` in a field config.
* `postgresql_anonymizer` failed to build because it specifies
`extension/anon` for the `directory` field. Update the examination
of file prefixes in `prepare_sharedir_file` to allow subdirectories.
theory
force-pushed
the
fix-directory-more
branch
from
51f44cc to
f68df13
Compare
theory
added a commit
that referenced
this pull request
Jan 8, 2025
Force the extensions workflow to build the extensions known to have `directory` fields in their control files, so as to fix them. Upgrade to `trunk-test-tembo:8a3bd64-pg15` to get the fixes, made in c3154c (#888) and f68df13 (#891), and released in 8a3bd64 (#892). As a result of failures revealed by fixing these issues, also teach PL/Java where to find `libjvm.so` and the workflow to preload the `anon` module when testing postgresql_anonymizer.
theory
added a commit
that referenced
this pull request
Jan 8, 2025
Force the extensions workflow to build the extensions known to have `directory` fields in their control files, so as to fix them. Upgrade to `trunk-test-tembo:8a3bd64-pg15` to get the fixes, made in c3154c (#888) and f68df13 (#891), and released in 8a3bd64 (#892). As a result of failures revealed by fixing these issues, also teach PL/Java where to find `libjvm.so` and the workflow to preload the `anon` module when testing postgresql_anonymizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues working with the
directoryfield from control files:emajfailed to work because it has a tab on thedirectoryline of its control file. Fixstrip_valueto account for any and all blank space on either side of the=in a field config.postgresql_anonymizerfailed to build because it specifiesextension/anonfor thedirectoryfield. Update the examination of file prefixes inprepare_sharedir_fileto allow subdirectories.