Always download DuckDB DSO #909
Merged
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
theory
added a commit
that referenced
this pull request
Jan 23, 2025
Rather than letting the Git repo build it from a submodule. Otherwise the pg_duckdb builder installs it into the Postgres lib directory, which isn't included in `ld`'s path, so Postgres can't find it. Update to `trunk-test-tembo:4436f19`, which includes the supported version of `libduckdb.so`. Also configure it to be added to `shared_preload_libraries` and needing to restart. While at it, use an explicit version when building duckdb_fdw.
theory
force-pushed
the
use-duckdb-release-so
branch
from
e70e2bd to
224a0f2
Compare
theory
added a commit
that referenced
this pull request
Jan 23, 2025
Rather than letting the Git repo build it from a submodule. Otherwise the pg_duckdb builder installs it into the Postgres lib directory, which isn't included in `ld`'s path, so Postgres can't find it. Update to `trunk-test-tembo:4436f19`, which includes the supported version of `libduckdb.so`. Also configure it to be added to `shared_preload_libraries` and needing to restart. While at it, use an explicit version when building duckdb_fdw.
theory
force-pushed
the
use-duckdb-release-so
branch
from
224a0f2 to
628c176
Compare
theory
added a commit
that referenced
this pull request
Jan 23, 2025
Rather than letting the Git repo build it from a submodule. Otherwise the pg_duckdb builder installs it into the Postgres lib directory, which isn't included in `ld`'s path, so Postgres can't find it. Update to `trunk-test-tembo:4436f19`, which includes the supported version of `libduckdb.so`. Also configure it to be added to `shared_preload_libraries` and needing to restart. Copy the same `libduckdb.so` to build `duckdb_fdw`, too, and explicitly set its version, since it may diverge from `duckdb_fdw`'s own version. The build is successful, but `duckdb_fdw` does not load with the `libduckdb.so` built by `pg_duckdb`, so skip testing it for now. Will fix once duckdb/pg_duckdb#554 or its successor resolves thing such that both extensions can use the same DSO.
theory
force-pushed
the
use-duckdb-release-so
branch
from
628c176 to
24a5278
Compare
Rather than letting the Git repo build it from a submodule. Otherwise the pg_duckdb builder installs it into the Postgres lib directory, which isn't included in `ld`'s path, so Postgres can't find it. Update to `trunk-test-tembo:4436f19`, which includes the supported version of `libduckdb.so`. Also configure it to be added to `shared_preload_libraries` and needing to restart. Copy the same `libduckdb.so` to build `duckdb_fdw`, too, and explicitly set its version, since it may diverge from `duckdb_fdw`'s own version. The build is successful, but `duckdb_fdw` does not load with the `libduckdb.so` built by `pg_duckdb`, so skip testing it for now. Will fix once duckdb/pg_duckdb#554 or its successor resolves thing such that both extensions can use the same DSO.
theory
force-pushed
the
use-duckdb-release-so
branch
from
24a5278 to
9268323
Compare
vrmiguel
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than letting the Git repo build it from a submodule. Otherwise the pg_duckdb builder installs it into the Postgres lib directory, which isn't included in
ld's path, so Postgres can't find it. Update totrunk-test-tembo:4436f19, which includes the supported version oflibduckdb.so.Also configure it to be added to
shared_preload_librariesand needing to restart.Copy the same
libduckdb.soto buildduckdb_fdw, too, and explicitly set its version, since it may diverge fromduckdb_fdw's own version. The build is successful, butduckdb_fdwdoes not load with thelibduckdb.sobuilt bypg_duckdb, so skip testing it for now. Will fix once duckdb/pg_duckdb#554 or its successor resolves thing such that both extensions can use the same DSO.