Skip to content

Commit

Permalink
Pick up ringpop-go#16 fix (#6841)
Browse files Browse the repository at this point in the history 
## What changed?
Pick up race fix from temporalio/ringpop-go#16

## Why?
fix rare data race

## How did you test it?
will be tested in CI, release validation

## Potential risks
low, the previous code already obtained the same rlock on the same path,
so there shouldn't be any risk of new deadlocks
  • Loading branch information
@dnr
dnr authored Nov 19, 2024
1 parent 02e2b93 commit c7a7ec7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion go.mod
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ require (
github.com/robfig/cron/v3 v3.0.1
github.com/sony/gobreaker v1.0.0
github.com/stretchr/testify v1.9.0
github.com/temporalio/ringpop-go v0.0.0-20240718232345-e2a435d149b6
github.com/temporalio/ringpop-go v0.0.0-20241119001152-e505ebd8f887
github.com/temporalio/sqlparser v0.0.0-20231115171017-f4060bcfa6cb
github.com/temporalio/tchannel-go v1.22.1-0.20240528171429-1db37fdea938
github.com/temporalio/tctl-kit v0.0.0-20230328153839-577f95d16fa0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
github.com/temporalio/ringpop-go v0.0.0-20240718232345-e2a435d149b6 h1:LnuIZntMSwZJS0O9b9bA+3iUL+Cwwhk+838PB04XLz4=
github.com/temporalio/ringpop-go v0.0.0-20240718232345-e2a435d149b6/go.mod h1:RE+CHmY+kOZQk47AQaVzwrGmxpflnLgTd6EOK0853j4=
github.com/temporalio/ringpop-go v0.0.0-20241119001152-e505ebd8f887 h1:08Y1jDl4UKVu+TiQHIVKcW6TKQaHl15vBKkcZ094/SA=
github.com/temporalio/ringpop-go v0.0.0-20241119001152-e505ebd8f887/go.mod h1:RE+CHmY+kOZQk47AQaVzwrGmxpflnLgTd6EOK0853j4=
github.com/temporalio/sqlparser v0.0.0-20231115171017-f4060bcfa6cb h1:YzHH/U/dN7vMP+glybzcXRTczTrgfdRisNTzAj7La04=
github.com/temporalio/sqlparser v0.0.0-20231115171017-f4060bcfa6cb/go.mod h1:143qKdh3G45IgV9p+gbAwp3ikRDI8mxsijFiXDfuxsw=
github.com/temporalio/tchannel-go v1.22.1-0.20220818200552-1be8d8cffa5b/go.mod h1:c+V9Z/ZgkzAdyGvHrvC5AsXgN+M9Qwey04cBdKYzV7U=
Expand Down

0 comments on commit c7a7ec7

Please sign in to comment.