Exit test after timeout #7118
Draft
Exit test after timeout #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
test-suite-timeout
branch
13 times, most recently
from
27b09d5 to
8a83088
Compare
stephanos
commented
Jan 18, 2025
Comment on lines
+34
to
+70
| rawStack := append(debug.Stack(), '\n', '\n') | ||
| _, _, err := stack.ScanSnapshot(bytes.NewReader(rawStack), os.Stdout, stack.DefaultOpts()) | ||
| if err != nil { | ||
| t.Logf("failed to parse stack trace: %v", err) | ||
| } |
There was a problem hiding this comment.
This output is a bit more readable than Go's default output.
stephanos
commented
Jan 18, 2025
Comment on lines
+271
to
+274
| - name: Highlight test timeout | ||
| if: ${{ steps.test_run.outcome == 'failure' && steps.test_run.outputs.exit_code == 124 }} | ||
| run: | | ||
| echo "::error::Test Test timed out" |
stephanos
force-pushed
the
test-suite-timeout
branch
4 times, most recently
from
87fa3f8 to
d6696c9
Compare
stephanos
commented
Jan 18, 2025
| @@ -244,10 +247,21 @@ func (s *FunctionalTestBase) SetupSuiteWithCluster(clusterConfigFile string, opt | |||
| func (s *FunctionalTestBase) SetupTest() { | |||
| s.checkTestShard() | |||
| s.initAssertions() | |||
| if s.testTimeout == nil { | |||
| s.testTimeout = newTestTimeout(s.T(), 30*time.Second*debug.TimeoutMultiplier) | |||
There was a problem hiding this comment.
Can't be in SetupSuite as the SDK functional test suite overrides that.
stephanos
force-pushed
the
test-suite-timeout
branch
from
d6696c9 to
d54bca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added per-test timeouts.
Unfortunately there's no way to stop a particular Goroutine from the outside. That's why
os.Exit- the nuclear option - is really the only choice IMO.Why?
Go only allows to set a timeout on the entire test run. But sometimes a single test is stuck and never going to complete. But you still have to wait for the very long timeout.
With this, at least it will fail fast.
How did you test it?
Potential risks
It could prematurely abort slower (non-stuck) tests - and require more tweaking of the timeouts for these. That could be annoying.
Documentation
Is hotfix candidate?