Fix Segmentation Fault in UnauthenticatedTenRPCCall in audit #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
reviewed
Jan 8, 2025
| @@ -64,18 +64,24 @@ func UnauthenticatedTenRPCCall[R any](ctx context.Context, w *services.Services, | |||
|
|
|||
| res, err := cache.WithCache(w.RPCResponsesCache, cfg, generateCacheKey(cacheArgs), func() (*R, error) { | |||
| return services.WithPlainRPCConnection(ctx, w.BackendRPC, func(client *rpc.Client) (*R, error) { | |||
| var resp *R | |||
| var resp R | |||
There was a problem hiding this comment.
I don't remember the reason why it had to be a pointer.
I'm wondering if we were to make this back a pointer and leave the if at the end, would it still seg-fault?
There was a problem hiding this comment.
I also don't remember why *R was used here.
After some research I think we can keep *R and do explicit allocation var resp *R = new(R) as it protects us from nil pointer dereference.
What do you think? Should I switch back to *R?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
A segmentation fault was occurring during the audit function call while formatting RPC call results (res) and errors (err).
More details: https://github.com/ten-protocol/ten-internal/issues/4479
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks