add enterprise image build step to ci #114
Conversation
Signed-off-by: xieydd <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
| file: ./docker/pg-slim/Dockerfile | ||
| build-args: | | ||
| PG_MAJOR=${{ matrix.version }} | ||
| tags: modelzai/pg-slim:${{ matrix.version }}-${{ matrix.platform }} |
There was a problem hiding this comment.
No need, this is basically immutable.
There was a problem hiding this comment.
Why do we need the pg_slim in this repo since it already exists in pgvecto.rs?
There was a problem hiding this comment.
We can only maintain it in this repository, the pgvecto.rs repository will be deleted.
There was a problem hiding this comment.
What does pg-slim do? It looks like a compiled postgres for docker usage. I think it's not related to the extension and will not be released with the extension. Can we create another repo or use the cnpg repo?
There was a problem hiding this comment.
We need to specify the datarootdir and libdir in mutable storage during the Postgres building, as the lib folder in our cluster is mounted on an EBS, so it is mutable, rather than in the immutable directory of the default Postgres image. This is mainly determined by the Kubernetes security context readOnlyRootFilesystem.
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
|
Other parts LGTM. Shall we move the pg-slim to another repo? cc @gaocegege |
In the best case, we should maintain it in a separate repo. But I am OK with this. |
No description provided.