[*.py] Rename "Arguments:" to "Args:" #604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
technique:clustering
|
Thank you for your contribution @SamuelMarks, and sorry for taking so long to review this. Could you please update this PR to cover recently merged [experimental](https://github.com/tensorflow/model-optimization/tree/master/tensorflow_model_optimization/python/core/clustering/keras/experimental modules)? @daverim, please review this change. |
SamuelMarks
force-pushed
the
args-for-google-style-docstrings
branch
from
0867601 to
4f4e5d0
Compare
|
@akarmi That should do the trick |
Thank you! LGTM. |
akarmi
approved these changes
Jan 28, 2021
|
@daverim, please check this change. |
SamuelMarks
force-pushed
the
args-for-google-style-docstrings
branch
from
1e79b7c to
53d2425
Compare
|
@akarmi Okay I merged in master (again) |
github-actions
bot
added
the
technique:qat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written custom parsers and emitters for everything from docstrings to classes and functions. However, I recently came across an issue with the TensorFlow codebase: inconsistent use of
Args:andArguments:in its docstrings. It is easy enough to extend my parsers to support both variants, however it looks likeArguments:is wrong anyway, as per:https://google.github.io/styleguide/pyguide.html#doc-function-args @
ddccc0fhttps://chromium.googlesource.com/chromiumos/docs/+/master/styleguide/python.md#describing-arguments-in-docstrings @
9fc0fc0https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html @
c0ae8e3Therefore, only
Args:is valid. This PR replaces them throughout the codebase.PS: For related PRs, see tensorflow/tensorflow/pull/45420