Add benchmarks #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| """Script to use run_inference from command line | ||
| Below is a complete command line for running this script | ||
| for benchmarks |
| type=str, | ||
| help='Path to the data file(s) containing data.') | ||
| parser.add_argument( | ||
| '--output', |
There was a problem hiding this comment.
The script will still run without output, which is why I don't think it should be a positional argument. But I made it required as it might be nice to know where the output is
Comment on lines
+47
to
+54
| parser.add_argument( | ||
| 'model_path', | ||
| type=str, | ||
| help='The path to input model') | ||
| parser.add_argument( | ||
| 'input', | ||
| type=str, | ||
| help='Path to the data file(s) containing data.') |
There was a problem hiding this comment.
These 2 are also required, right?
There was a problem hiding this comment.
Yea and without -- in front, these two won't be interpreted as optional
|
|
||
| setup_options = options.view_as(SetupOptions) | ||
| # Path of the wheel file tfx-bsl | ||
| setup_options.extra_packages = ['./tfx-bsl/dist/tfx_bsl-0.23.0.dev0-cp37-cp37m-linux_x86_64.whl'] |
There was a problem hiding this comment.
Can this be another argument to pass in?
| setup_options.save_main_session = save_main_session | ||
|
|
||
| def get_saved_model_spec(model_path): | ||
| '''returns an InferenceSpecType object for a saved model path''' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.