Add Executor CLI arg that defines port range used for Function Executors #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eabatalov
force-pushed
the
eugene-addr-reuse
branch
from
c86c906 to
79057aa
Compare
Also disable port reuse in Function Executor gRPC Servers and fail if a wrong task was routed to a Function Executor. Previously all these scenarios produced undefined behavior. This allows to run multiple Executors on the same machine which is convenient for Indexify development, users experimentation with their workflows and to implement integ tests that require multiple Executors. This also provides clear and early error messages in case the ports got misconfigured and if Executor -> Function Executor routing is misbehaving.
eabatalov
force-pushed
the
eugene-addr-reuse
branch
from
79057aa to
0da4d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disable port reuse in Function Executor gRPC Servers and fail if a wrong task was routed to a Function Executor. Previously all these scenarios produced undefined behavior.
This allows to run multiple Executors on the same machine which is convenient for Indexify development, users experimentation with their workflows and to implement integ tests that require multiple Executors.
This also provides clear and early error messages in case the ports got misconfigured and if Executor -> Function Executor routing is misbehaving.