Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ag grid update theming #4171

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Ag grid update theming #4171

merged 4 commits into from
Jan 15, 2025

Conversation

simonseyock
Copy link
Member

@simonseyock simonseyock commented Jan 15, 2025

Description

This updates AG-Grid to v33. This changes the npm package names and introduces a new way to theme the grid via react properties. This is easier to customize and is similar to the new antd way.

This is a breaking change.

This is how the old version (left side) looks compared to the new version (right side):
image

This PR also adds some documentation about theming with antd.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm run check locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

BREAKING CHANGE: The theme property of the AgFeatureGrid has changed to an AG-Grid Theme object.
Any CSS imports from AG-Grid have to be removed.
@simonseyock simonseyock force-pushed the ag-grid-update-theming branch from 3f3dac8 to 3fc107a Compare January 15, 2025 13:21
@simonseyock simonseyock merged commit babc329 into main Jan 15, 2025
2 checks passed
@simonseyock simonseyock deleted the ag-grid-update-theming branch January 15, 2025 14:09
@dnlkoch
Copy link
Member

dnlkoch commented Jan 15, 2025

🎉 This PR is included in version 27.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants