fix: fixing some issues derived from the review

terrestris · Jan 2, 2025 · c861dc6 · c861dc6
1 parent fa7e482
commit c861dc6
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/src/components/StylingDrawer/index.tsx b/src/components/StylingDrawer/index.tsx
@@ -46,7 +46,6 @@ export const StylingDrawer: React.FC<StylingDrawerProps> = ({
   } = useTranslation();
 
   useEffect(() => {
-
     if (!layerUid) {
       setIsImageLayer(false);
     }

diff --git a/src/components/ToolMenu/LayerTree/LayerTreeContextMenu/index.tsx b/src/components/ToolMenu/LayerTree/LayerTreeContextMenu/index.tsx
@@ -103,7 +103,6 @@ export const LayerTreeContextMenu: React.FC<LayerTreeContextMenuProps> = ({
     t
   } = useTranslation();
 
-  const drawerVisibilty = useAppSelector(state => state.stylingDrawerVisibility);
   const downloadConfig: DownloadConfig[] = layer.get('downloadConfig') ?? null;
   const allowedEditMode = useAppSelector(
     state => state.editFeature.userEditMode
@@ -257,8 +256,10 @@ export const LayerTreeContextMenu: React.FC<LayerTreeContextMenuProps> = ({
   };
 
   const configureStyles = () => {
-    dispatch(setStylingDrawerVisibility(true));
-    dispatch(setStylingDrawerLayerUid(getUid(layer)));
+    if (layer) {
+      dispatch(setStylingDrawerVisibility(true));
+      dispatch(setStylingDrawerLayerUid(getUid(layer)));
+    }
   };
 
   const dropdownMenuItems: ItemType[] = [];
@@ -324,7 +325,7 @@ export const LayerTreeContextMenu: React.FC<LayerTreeContextMenuProps> = ({
   }
   if (isGeoserverLayer) {
     dropdownMenuItems.push({
-      label: 'Geostyler',
+      label: t('LayerTreeContextMenu.styleLayer'),
       key: 'geostyler'
     });
   }

diff --git a/src/i18n/translations.ts b/src/i18n/translations.ts
@@ -90,7 +90,8 @@ export default {
         hideLegend: 'Legende ausblenden',
         downloadLayer: 'Layer exportieren ({{formatName}})',
         editLayer: 'Layer bearbeiten',
-        layerDetails: 'Eigenschaften'
+        layerDetails: 'Eigenschaften',
+        styleLayer: 'Layer Stil'
       },
       LayerDetailsModal: {
         title: 'Eigenschaften des Layers {{layerName}}',
@@ -386,7 +387,8 @@ export default {
         hideLegend: 'Hide legend',
         downloadLayer: 'Export layer as {{formatName}}',
         editLayer: 'Edit layer',
-        layerDetails: 'Properties'
+        layerDetails: 'Properties',
+        styleLayer: 'Layer style'
       },
       LayerDetailsModal: {
         title: 'Properties of layer {{layerName}}',

diff --git a/src/utils/geoserverUtils.tsx b/src/utils/geoserverUtils.tsx
@@ -104,15 +104,13 @@ export const fetchGeoserverStyle = async (
   }
 };
 
-export const getLayerUrl = (layerSource: Source | undefined): string | false => {
-  if (!layerSource) {
-    return false;
-  }
+export const getLayerUrl = (layerSource: Source | undefined): string | undefined => {
+
   let url: string | undefined;
   if (layerSource instanceof TileWMS || layerSource instanceof ImageWMS) {
     url = layerSource instanceof TileWMS ? layerSource.getUrls()?.[0] : layerSource.getUrl();
   }
-  return url || false;
+  return url || undefined;
 };
 
 export const checkIfGeoserverLayer = (layerSource: Source | undefined): boolean => {