Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update global loading mask #1760

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Update global loading mask #1760

merged 1 commit into from
Nov 7, 2024

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Nov 7, 2024

This updates the loading mask by:

  • removing the static Please wait, loading… since it's not translatable
  • adding an animated loading indicator instead
  • cleaning up the css

Peek 2024-11-07 10-56

Please review @terrestris/devs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

null

LukasLohoff
LukasLohoff approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@LukasLohoff LukasLohoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good now!

Unrelated to these changes: I think the fade-away animation would look better if the shogun_spinner.gif had a transparent background.

@KaiVolland
Copy link
Member

IMHO the loading indicator is not needed as the leaf already has a spinning cog.

@dnlkoch
Copy link
Member Author

dnlkoch commented Nov 7, 2024

Unrelated to these changes: I think the fade-away animation would look better if the shogun_spinner.gif had a transparent background.

Good point! I tried to change the background, but couldn't fix it :-/

IMHO the loading indicator is not needed as the leaf already has a spinning cog.

Yes, the default one is already animated, but the logo is usually changed in instances (to non-animated ones).

@dnlkoch
Copy link
Member Author

dnlkoch commented Nov 7, 2024

Thanks for the reviews!

@dnlkoch dnlkoch merged commit 0458ddc into next Nov 7, 2024
1 check passed
@dnlkoch dnlkoch deleted the update-loading-mask branch November 7, 2024 14:08
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 9.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasLohoff LukasLohoff LukasLohoff approved these changes

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnlkoch @KaiVolland @LukasLohoff