Fix link to Charge Level dashboard #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this link that should probably go to the charge level dashboard. Also, semi-related, is there a reason all the uid's are random numbers? These are the uid's that appear in the URL of the dasboard. I changed them on my instance to more readable uid's, is this something that would be approved if I changed all the uid's of the dashboards, and fix all the links? The only breaking change I can foresee is bookmarked dashboards become invalid.
Median is a different calculation than average/mean. I don't think Grafana even supports calculating the median.
JakobLichterfeld
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Fix link to Charge Level dashboard (DrM: not sure, whether that makes it through) I noticed this link that should probably go to the charge level dashboard. Also, semi-related, is there a reason all the uid's are random numbers? These are the uid's that appear in the URL of the dasboard. I changed them on my instance to more readable uid's, is this something that would be approved if I changed all the uid's of the dashboards, and fix all the links? The only breaking change I can foresee is bookmarked dashboards become invalid. * Change wording from "median" to "average" since the mean is calculated Median is a different calculation than average/mean. I don't think Grafana even supports calculating the median. --------- Co-authored-by: DrMichael <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this link that should probably go to the charge level dashboard.
Also, semi-related, is there a reason all the uid's are random numbers? These are the uid's that appear in the URL of the dasboard. I changed them on my instance to more readable uid's, is this something that would be approved if I changed all the uid's of the dashboards, and fix all the links? The only breaking change I can foresee is bookmarked dashboards become invalid.