Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charges.json: Add cost/kWh #3537

Closed
wants to merge 2 commits into from
Closed

Update charges.json: Add cost/kWh #3537

wants to merge 2 commits into from

Conversation

DrMichael
Copy link
Collaborator

Add cost per kWh per #3536

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit c0f8270
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/656b6930676f110008d9f4ad
😎 Deploy Preview https://deploy-preview-3537--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DrMichael
Copy link
Collaborator Author

DrMichael commented Dec 2, 2023

Still learning: How would I request a review?
Now it is neitther in egde nor in latest
It was added in 639f9cb and somehow diappeared, what I cannot see in the history. Strange.

@NirKli
Copy link
Contributor

NirKli commented Dec 2, 2023

Still learning: How would I request a review? I am puzzled: it is already in egde, but not in latest?

This is how to request a review. It will be included in the latest release once this PR (Pull Request) is merged. (Depends on the CI )

@DrMichael
Copy link
Collaborator Author

Hmmm, cost_per_kwh is in github, but it is neither in edge nor in latest. But is in the current version of the last commit to charges.json. I am lost.
@JakobLichterfeld Am I doing something wrong here?

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Dec 3, 2023

It was added in 639f9cb and somehow diappeared, what I cannot see in the history. Strange.

You can look into file history, latest change was your mentioned PR, see https://github.com/teslamate-org/teslamate/commits/639f9cba4e4e77d4fb009c3fae46fce05d8e2d4a/grafana/dashboards/charges.json

And the edits are in master:

"options": "cost_per_kwh"

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Dec 3, 2023

Still learning: How would I request a review? Now it is neitther in egde nor in latest It was added in 639f9cb and somehow diappeared, what I cannot see in the history. Strange.

see https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

@JakobLichterfeld JakobLichterfeld added area:dashboard Related to a Grafana dashboard note:needs investigation The issue must be investigated first labels Dec 3, 2023
@JakobLichterfeld
Copy link
Collaborator

If you need assistance with Dashboards, maybe @swiffer can assist

@DrMichael
Copy link
Collaborator Author

You can look into file history, latest change was your mentioned PR, see https://github.com/teslamate-org/teslamate/commits/639f9cba4e4e77d4fb009c3fae46fce05d8e2d4a/grafana/dashboards/charges.json

And the edits are in master:

"options": "cost_per_kwh"

Yes, that is, what confuses me. It is in the latest history, it is in master, but it does not show up in edge nore in latest.

@DrMichael DrMichael self-assigned this Dec 4, 2023
@DrMichael DrMichael marked this pull request as draft December 4, 2023 12:57
@DrMichael
Copy link
Collaborator Author

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Dec 4, 2023

@DrMichael you can test these changes with the dedicated grafana image: ghcr.io/teslamate-org/teslamate/grafana:pr-3537
https://github.com/teslamate-org/teslamate/pkgs/container/teslamate%2Fgrafana/153840916?tag=pr-3537

@DrMichael
Copy link
Collaborator Author

I found the issue. the calculation for cost/kWh is missing in the master version. So it does not appear in latest and edge.
I will make a new PR...

@DrMichael DrMichael closed this Dec 4, 2023
@DrMichael
Copy link
Collaborator Author

@DrMichael you can test these changes with the dedicated grafana image: ghcr.io/teslamate-org/teslamate/grafana:pr-3537 https://github.com/teslamate-org/teslamate/pkgs/container/teslamate%2Fgrafana/153840916?tag=pr-3537

Yes, got that. Great new feature! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard note:needs investigation The issue must be investigated first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants